[webkit-reviews] review denied: [Bug 111178] CSS debugging code is broken : [Attachment 190960] Patch

[bugzilla-daemon at webkit.org]

Mark Rowe (bdash) <mrowe at apple.com> has denied Sergey Ryazanov
<serya at chromium.org>'s request for review:
Bug 111178: CSS debugging code is broken
https://bugs.webkit.org/show_bug.cgi?id=111178

Attachment 190960: Patch
https://bugs.webkit.org/attachment.cgi?id=190960&action=review

------- Additional Comments from Mark Rowe (bdash) <mrowe at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=190960&action=review


> Source/WebCore/ChangeLog:3
> +	   Fixed.

This is  unnecessary.

> Source/WebCore/ChangeLog:5
> +	   CSS debugging code is broken

This is too vague.

> Source/WebCore/ChangeLog:16
> +	   * css/CSSGrammar.y.includes:
> +	   * css/CSSParser.cpp:
> +	   (WebCore::CSSParser::rewriteSpecifiers):
> +	   * css/CSSParser.h:
> +	   (WebCore):

These are here so you can provide a description of what changes you made, and
why.

> Source/WebCore/css/CSSParser.cpp:11964
> +String yylvalToString(int yytype, const void* yylvalWithoutType)

Why is this implemented unconditionally when it's only ever used when YYDEBUG
is > 0?

> Source/WebCore/css/CSSParser.h:713
> +

Why is this defined unconditionally when it's only ever used when YYDEBUG is >
0?