[webkit-reviews] review granted: [Bug 111234] Don't leak Documents when using MutationObserver from extensions : [Attachment 191079] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Elliott Sprehn
<esprehn at chromium.org>'s request for review:
Bug 111234: Don't leak Documents when using MutationObserver from extensions
https://bugs.webkit.org/show_bug.cgi?id=111234

Attachment 191079: Patch
https://bugs.webkit.org/attachment.cgi?id=191079&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=191079&action=review


We should eventually replace all uses of WorldContextHandle with this
mechanism.

> Source/WebCore/bindings/v8/V8Binding.cpp:278
> +	       return
v8::Local<v8::Context>::New(frame->script()->windowShell(world)->context());

It it possible that windowShell(world) will return null?  I guess not if the
context is active in the frame.

> Source/WebCore/bindings/v8/V8Binding.cpp:282
> +	   if (WorkerScriptController* script =
static_cast<WorkerContext*>(context)->script())

Is it possible for script() to return null here?  That seems like it would be
an odd situation...