[webkit-reviews] review granted: [Bug 97510] Some perf. tests have variances that differ greatly between runs : [Attachment 190831] Fixed a harness test

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 97510: Some perf. tests have variances that differ greatly between runs
https://bugs.webkit.org/show_bug.cgi?id=97510

Attachment 190831: Fixed a harness test
https://bugs.webkit.org/attachment.cgi?id=190831&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=190831&action=review


I can't wait to see the result on the bots.

> PerformanceTests/Dromaeo/resources/dromaeorunner.js:9
>	    setup: function(testName) {
> -		PerfTestRunner.prepareToMeasureValuesAsync({iterationCount: 5,
doNotMeasureMemoryUsage: true, doNotIgnoreInitialRun: true, unit: 'runs/s'});
> +	       
PerfTestRunner.prepareToMeasureValuesAsync({dromaeoIterationCount: 5,
doNotMeasureMemoryUsage: true, doNotIgnoreInitialRun: true, unit: 'runs/s'});
>  
>		var iframe = document.createElement("iframe");
> -		var url = DRT.baseURL + "?" + testName + '&numTests=' +
PerfTestRunner.iterationCount();
> +		var url = DRT.baseURL + "?" + testName + '&numTests=' + 5;

var dromaeoIterationCount;
PerfTestRunner.prepareToMeasureValuesAsync({dromaeoIterationCount:
dromaeoIterationCount, Foobar)
[...]
var url = DRT.baseURL + "?" + testName + '&numTests=' + dromaeoIterationCount;

> PerformanceTests/resources/runner.js:158
> +	   iterationCount = test.dromaeoIterationCount || (window.testRunner ?
5 : 20);

Damn, JavaScript is ugly :-D

> Tools/Scripts/webkitpy/performance_tests/perftest.py:110
> +    def __init__(self, port, test_name, test_path, process_count=4):

process_count -> process_run_count or something alike?

> Tools/Scripts/webkitpy/performance_tests/perftest.py:134
> +	   for _ in range(0, self._process_count):

xrange?

Gosh I hate python sometime :)

> Tools/Scripts/webkitpy/performance_tests/perftest.py:138
> +		   if not self._run_with_driver(driver, time_out_ms):
> +		       return None

You may have 3 run with results and one that failed?