[webkit-reviews] review denied: [Bug 110939] Move markerTextForListItem from TestRunner to Internals : [Attachment 191058] Patch

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has denied Jason Anderssen
<janderssen at gmail.com>'s request for review:
Bug 110939: Move markerTextForListItem from TestRunner to Internals
https://bugs.webkit.org/show_bug.cgi?id=110939

Attachment 191058: Patch
https://bugs.webkit.org/attachment.cgi?id=191058&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=191058&action=review


> Source/WebCore/testing/Internals.cpp:2019
> +    return WebCore::markerTextForListItem(element);

Internals is in the WebCore namespace, you do not need the WebCore:: prefix
here.

> Tools/DumpRenderTree/blackberry/TestRunnerBlackBerry.cpp:517
> -JSRetainPtr<JSStringRef> TestRunner::markerTextForListItem(JSContextRef
context, JSValueRef nodeObject) const
> +JSRetainPtr<JSStringRef> TestRunner::layerTreeAsText() const
>  {
> -    WebCore::Element* element = toElement(toJS(toJS(context), nodeObject));
> -    if (!element)
> -	   return 0;
> -
> -    JSRetainPtr<JSStringRef> markerText(Adopt,
JSStringCreateWithUTF8CString(WebCore::markerTextForListItem(element).utf8().da
ta()));
> -    return markerText;
> +    notImplemented();
> +    return 0;
>  }

Not sure why you change this to layerTreeAsText(). You can just remove all the
code.