[webkit-reviews] review granted: [Bug 110818] [WebGL] Support for texImage2D of type HALF_FLOAT_OES with ArrayBufferView. : [Attachment 191045] Patch

[bugzilla-daemon at webkit.org]

Kenneth Russell <kbr at google.com> has granted Nayan Kumar K
<nayankk at motorola.com>'s request for review:
Bug 110818: [WebGL] Support for texImage2D of type HALF_FLOAT_OES with
ArrayBufferView.
https://bugs.webkit.org/show_bug.cgi?id=110818

Attachment 191045: Patch
https://bugs.webkit.org/attachment.cgi?id=191045&action=review

------- Additional Comments from Kenneth Russell <kbr at google.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=191045&action=review


Thanks for the updates. I suppose it's OK to add the webgl/ copies of the
layout tests later. Please make the few corrections above before landing, and
make sure it passes the EWS. r=me

> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:3816
> +    // Uploading ImageElement to half floating point texture is not
supported yet

FIXME:

> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:3817
> +    // https://bugs.webkit.org/show_bug.cgi?id=111194

Is it really worth having all of these bugs for all of these different types? I
suspect that once you have the core data packing support in place that
supporting each of them will be a few lines of code each.

> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:3844
> +    // Uploading HTMLCanvasElement to half floating point texture is not
supported yet

FIXME:

> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:3906
> +    // Uploading HTMLVideoElement to half floating point texture is not
supported yet

FIXME:

> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:4067
> +    // Uploading ImageData to half floating point texture is not supported
yet

FIXME:

> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:4105
> +    // Uploading HTMLImageElement to half floating point texture is not
supported yet

FIXME:

> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:4133
> +    // Uploading HTMLCanvasElement to half floating point texture is not
supported yet

FIXME:

> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:4157
> +    // Uploading HTMLVideoElement to half floating point texture is not
supported yet

FIXME:

> Source/WebCore/html/canvas/WebGLRenderingContext.idl:1
> + /*

Undo this change please.