[webkit-reviews] review denied: [Bug 110291] Move WebCore feature defines to the WebCore directory : [Attachment 191053] rename FeatureDefines to WebCoreFeatureDefines

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 1 15:43:03 PST 2013


Adam Barth <abarth at webkit.org> has denied Laszlo Gombos
<laszlo.gombos at webkit.org>'s request for review:
Bug 110291: Move WebCore feature defines to the WebCore directory
https://bugs.webkit.org/show_bug.cgi?id=110291

Attachment 191053: rename FeatureDefines to WebCoreFeatureDefines
https://bugs.webkit.org/attachment.cgi?id=191053&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=191053&action=review


> Tools/DumpRenderTree/chromium/config.h:34
> +#include <WebCore/WebCoreFeatureDefines.h>

DumpRenderTree is not allowed to depend on WebCore directly in Chromium.


More information about the webkit-reviews mailing list