[webkit-reviews] review granted: [Bug 111002] IndexedDB: Avoid ScriptValue copies in IDBAny : [Attachment 190597] Patch

[bugzilla-daemon at webkit.org]

Adam Barth <abarth at webkit.org> has granted Alec Flett
<alecflett at chromium.org>'s request for review:
Bug 111002: IndexedDB: Avoid ScriptValue copies in IDBAny
https://bugs.webkit.org/show_bug.cgi?id=111002

Attachment 190597: Patch
https://bugs.webkit.org/attachment.cgi?id=190597&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=190597&action=review


> Source/WebCore/Modules/indexeddb/IDBAny.h:122
> +    IDBAny(Type);
> +    IDBAny(PassRefPtr<DOMStringList>);
> +    IDBAny(PassRefPtr<IDBCursor>);
> +    IDBAny(PassRefPtr<IDBCursorWithValue>);
> +    IDBAny(PassRefPtr<IDBDatabase>);
> +    IDBAny(PassRefPtr<IDBFactory>);
> +    IDBAny(PassRefPtr<IDBIndex>);
> +    IDBAny(PassRefPtr<IDBObjectStore>);
> +    IDBAny(PassRefPtr<IDBTransaction>);
> +    IDBAny(const IDBKeyPath&);
> +    IDBAny(const String&);
> +    IDBAny(const ScriptValue&);
> +    IDBAny(int64_t);

Should these be marked explicit?

> Source/WebCore/Modules/indexeddb/IDBAny.h:127
> +    const RefPtr<DOMStringList> m_domStringList;

const RefPtr is sort of unusual in WebCore, but I guess it's fine.