[webkit-reviews] review denied: [Bug 111088] Objective-C API: Need a good way to reference event handlers without causing cycles : [Attachment 190846] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 1 13:33:10 PST 2013


Gavin Barraclough <barraclough at apple.com> has denied Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 111088: Objective-C API: Need a good way to reference event handlers
without causing cycles
https://bugs.webkit.org/show_bug.cgi?id=111088

Attachment 190846: patch
https://bugs.webkit.org/attachment.cgi?id=190846&action=review

------- Additional Comments from Gavin Barraclough <barraclough at apple.com>
Per our discussion, please use DEFINE_STATIC_LOCAL thingumy,
maybe add a JSWeakValue parent type
make marking an obj-c wrapper make the obj-c object an opaque root
and change the owner to be the actual obj-c object rather than it's wrapper

cheers, G.


More information about the webkit-reviews mailing list