[webkit-reviews] review granted: [Bug 111135] Threaded HTML Parser has an extra copy of every byte from the network : [Attachment 190986] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 1 12:22:22 PST 2013


Adam Barth <abarth at webkit.org> has granted Eric Seidel <eric at webkit.org>'s
request for review:
Bug 111135: Threaded HTML Parser has an extra copy of every byte from the
network
https://bugs.webkit.org/show_bug.cgi?id=111135

Attachment 190986: Patch
https://bugs.webkit.org/attachment.cgi?id=190986&action=review

------- Additional Comments from Adam Barth <abarth at webkit.org>
I understand benjaminp's concerns, but I think we should still move forward
with this patch.  It's true that we're creating a tighter coupling between the
HTML parser and the charset decoder, but I don't see a way around that with our
current string mechanism.  (The ASSERT helps us maintain the invariant, so we
should be well-covered w.r.t. testing.)

In the long term, we should think about how to make it easier to write
multithreaded code that uses strings in WebCore.  The current String class is
really difficult to use on multiple threads correctly.


More information about the webkit-reviews mailing list