[webkit-reviews] review granted: [Bug 111153] [BlackBerry] New files for BlackBerry::Platform::Graphics::GraphicsContext integration : [Attachment 190987] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 1 10:49:28 PST 2013


Rob Buis <rwlbuis at gmail.com> has granted Arvid Nilsson <anilsson at rim.com>'s
request for review:
Bug 111153: [BlackBerry] New files for
BlackBerry::Platform::Graphics::GraphicsContext integration
https://bugs.webkit.org/show_bug.cgi?id=111153

Attachment 190987: Patch
https://bugs.webkit.org/attachment.cgi?id=190987&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=190987&action=review


LGTM.

> Source/WebCore/platform/graphics/blackberry/FontCacheBlackBerry.cpp:23
> +

Nit: we do the amount of spacing between licensing and includes inconsistently.
I personally would not do two, not zero, but likely one empty line.


More information about the webkit-reviews mailing list