[webkit-reviews] review denied: [Bug 111191] Web Inspector: add Ace editor experiment : [Attachment 190982] Patch

[bugzilla-daemon at webkit.org]

Pavel Feldman <pfeldman at chromium.org> has denied Andrey Lushnikov
<lushnikov at chromium.org>'s request for review:
Bug 111191: Web Inspector: add Ace editor experiment
https://bugs.webkit.org/show_bug.cgi?id=111191

Attachment 190982: Patch
https://bugs.webkit.org/attachment.cgi?id=190982&action=review

------- Additional Comments from Pavel Feldman <pfeldman at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=190982&action=review


Could you share the stats on how much bigger the front-end footprint will be?
In absolute numbers as well as percentage. Raw, minified and zipped (chromium
resources are zipped).

> Source/WebCore/inspector/front-end/AceTextEditor.js:48
> +    this.element.style.height = "100%";

Please use CSS for styling.

> Source/WebCore/inspector/front-end/AceTextEditor.js:84
> +	       case "text/html":
this._aceEditor.getSession().setMode("ace/mode/html"); break;

Do not indent case from switch.