[webkit-reviews] review denied: [Bug 108128] [css exclusions] setting shape-inside on a parent does not relayout child blocks' inline content : [Attachment 190659] Initial Patch

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has denied Bear Travis <betravis at adobe.com>'s
request for review:
Bug 108128: [css exclusions] setting shape-inside on a parent does not relayout
child blocks' inline content
https://bugs.webkit.org/show_bug.cgi?id=108128

Attachment 190659: Initial Patch
https://bugs.webkit.org/attachment.cgi?id=190659&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=190659&action=review


r-

> Source/WebCore/rendering/RenderBlock.cpp:1548
> +#if ENABLE(CSS_EXCLUSIONS)
> +    ExclusionShapeInsideInfo * info = exclusionShapeInsideInfo();
> +    if (info)
> +	   info->setNeedsLayout(info->shapeSizeDirty());
> +    if (!relayoutChildren && (info || (info =
layoutExclusionShapeInsideInfo())))
> +	   relayoutChildren = info->needsLayout();
> +#endif

Could this possibly be folded into updateRegionsAndExclusionsLogicalSize, with
that method returning a bool indicating whether or not relayoutChildren is
required? Just trying to reduce the footprint of this code in layoutBlock.