[webkit-reviews] review canceled: [Bug 110579] [GTK] Build libWebCorePlatform.la as libPlatform.la, libWebCoreGtk.la as libPlatformGtk.la : [Attachment 189964] Patch

[bugzilla-daemon at webkit.org]

Zan Dobersek <zandobersek at gmail.com> has canceled  review:
Bug 110579: [GTK] Build libWebCorePlatform.la as libPlatform.la,
libWebCoreGtk.la as libPlatformGtk.la
https://bugs.webkit.org/show_bug.cgi?id=110579

Attachment 189964: Patch
https://bugs.webkit.org/attachment.cgi?id=189964&action=review

------- Additional Comments from Zan Dobersek <zandobersek at gmail.com>
I've brought up the migration issue on the webkit-dev mailing list[1] and while
the discussion is somewhat still ongoing there are two conclusions already
drawn that affect this bug:
- the platform layer code (to be built into libPlatform(Gtk).la) must in no way
depend on WebCore,
- the migration will be incremental, moving source files after it is determined
they are independent of WebCore.

Because of that I'd recommend that libPlatform.la and libPlatformGtk.la are set
up as in the latest patch, but in no way stretching out to WebCore and used
alongside libWebCorePlatform.la and libWebCoreGtk.la, respectively. The source
files that are green-lit for the migration would then be moved under
Source/Platform and listed in the appropriate build target list. This would
allow for incremental migration without too much hassle in terms of build
failures for the GTK port.

Thoughts?

[1] https://lists.webkit.org/pipermail/webkit-dev/2013-February/024000.html