[webkit-reviews] review granted: [Bug 111072] [BlackBerry] Upstream BlackBerry::Platform::GraphicsContext integration related changes in platform/graphics/blackberry : [Attachment 190965] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Mar 1 08:11:35 PST 2013


Rob Buis <rwlbuis at gmail.com> has granted Arvid Nilsson <anilsson at rim.com>'s
request for review:
Bug 111072: [BlackBerry] Upstream BlackBerry::Platform::GraphicsContext
integration related changes in platform/graphics/blackberry
https://bugs.webkit.org/show_bug.cgi?id=111072

Attachment 190965: Patch
https://bugs.webkit.org/attachment.cgi?id=190965&action=review

------- Additional Comments from Rob Buis <rwlbuis at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=190965&action=review


Some nits but nothing that needs to be fixed in this patch.

> Source/WebCore/platform/graphics/blackberry/LayerFilterRenderer.cpp:33
> +#include <Vector.h>

Not an improvement, since the former is preferred. Does not need to be part of
this patch though.

> Source/WebCore/platform/graphics/blackberry/LayerFilterRenderer.cpp:304
> +    char standardVertexShaderString[] =

These could be const to move it into rodata. But not part of this patch...

> Source/WebCore/platform/graphics/blackberry/LayerRenderer.cpp:595
> +	   glDisable(GL_BLEND);

I see this structure recurring a lot, I wonder if we should make a helper
function.


More information about the webkit-reviews mailing list