[webkit-reviews] review granted: [Bug 105285] Web Inspector: [Styles] Implement navigation to UI locations of property names/values in the source code : [Attachment 190930] Patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Mar 1 05:05:22 PST 2013
Vsevolod Vlasov <vsevik at chromium.org> has granted Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 105285: Web Inspector: [Styles] Implement navigation to UI locations of
property names/values in the source code
https://bugs.webkit.org/show_bug.cgi?id=105285
Attachment 190930: Patch
https://bugs.webkit.org/attachment.cgi?id=190930&action=review
------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=190930&action=review
> Source/WebCore/inspector/front-end/StylesSidebarPane.js:1110
> + _isCSSNavigable: function(url)
Can we move this to WebInspector.CSSRule?
> Source/WebCore/inspector/front-end/StylesSidebarPane.js:2195
> + var range = this.property.range;
Can this piece of code be a method of Property?
More information about the webkit-reviews
mailing list