[webkit-reviews] review denied: [Bug 110960] Web Inspector: [Protocol] Turn SecurityOrigin into an object containing "domainSetInDOM" : [Attachment 190926] Patch

[bugzilla-daemon at webkit.org]

Vsevolod Vlasov <vsevik at chromium.org> has denied Alexander Pavlov (apavlov)
<apavlov at chromium.org>'s request for review:
Bug 110960: Web Inspector: [Protocol] Turn SecurityOrigin into an object
containing "domainSetInDOM"
https://bugs.webkit.org/show_bug.cgi?id=110960

Attachment 190926: Patch
https://bugs.webkit.org/attachment.cgi?id=190926&action=review

------- Additional Comments from Vsevolod Vlasov <vsevik at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=190926&action=review


> Source/WebCore/inspector/front-end/ResourceTreeModel.js:392
> +WebInspector.ResourceTreeModel.SecurityOriginTracker = function(model)

Let's extract SecurityOriginTracker related rafactoring from this patch.

> Source/WebCore/inspector/front-end/ResourceTreeModel.js:469
> +	   return origin || null;

securityOrigin is never null at this point.