[webkit-reviews] review denied: [Bug 111094] [Qt]clearMemoryCaches of QWebSettings should call GC to release references of CachedResource : [Attachment 190772] Patch

[bugzilla-daemon at webkit.org]

Simon Hausmann <hausmann at webkit.org> has denied Arunprasad
<ArunPrasadR at nds.com>'s request for review:
Bug 111094: [Qt]clearMemoryCaches of QWebSettings should call GC to release
references of CachedResource
https://bugs.webkit.org/show_bug.cgi?id=111094

Attachment 190772: Patch
https://bugs.webkit.org/attachment.cgi?id=190772&action=review

------- Additional Comments from Simon Hausmann <hausmann at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=190772&action=review


It sounds to me that this is a reasonable thing to do. Allan, what do you
think?

(r- because of #ifdefs that aren't needed)

> Source/WebKit/qt/Api/qwebsettings.cpp:49
> +#if USE(JSC)
> +#include "GCController.h"
> +#else    
> +#include "V8GCController.h"
> +#endif

We don't support v8 as underlying JS engine at this point, so I suggest to
remove the USE(JSC) and just use it directly.