[webkit-reviews] review granted: [Bug 118216] Avoid calling into Objective-C every time we get the scrollbar width : [Attachment 205771] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 118216: Avoid calling into Objective-C every time we get the scrollbar
width
https://bugs.webkit.org/show_bug.cgi?id=118216

Attachment 205771: Patch
https://bugs.webkit.org/attachment.cgi?id=205771&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=205771&action=review


r=me

> Source/WebCore/ChangeLog:12
> +	   is one that gets called when the user changes the setting in System
Preferences.

"is the function" maybe?

> Source/WebCore/platform/mac/ScrollbarThemeMac.mm:136
> +static bool gUseOverlayScrollbars = false;

Can we call this gUsesOverlayScrollbars, to match the function name? (I added
an 's'.)