[webkit-reviews] review granted: [Bug 118212] Adopt is/toHTMLOptionElement for code cleanup : [Attachment 205763] Patch

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has granted Kangil Han
<kangil.han at samsung.com>'s request for review:
Bug 118212: Adopt is/toHTMLOptionElement for code cleanup
https://bugs.webkit.org/show_bug.cgi?id=118212

Attachment 205763: Patch
https://bugs.webkit.org/attachment.cgi?id=205763&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=205763&action=review


r=me

> Source/WebCore/html/HTMLCollection.cpp:227
>	   if (element->hasLocalName(optionTag)) {

I wonder if we could use isHTMLOptionElement() here instead of just checking
the localName.

> Source/WebCore/html/HTMLSelectElement.cpp:244
> +	   if (items[i]->hasLocalName(optionTag)) {

Ditto.

> Source/WebCore/html/HTMLSelectElement.cpp:265
>	   if (items[i]->hasLocalName(optionTag)) {

Ditto.

> Source/WebCore/html/HTMLSelectElement.cpp:979
>	   if (!items[i]->hasLocalName(optionTag))

Ditto.