[webkit-reviews] review granted: [Bug 117864] An element with -webkit-user-select: all should be selected on single click : [Attachment 205150] Fixed non-mac builds

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 117864: An element with -webkit-user-select: all should be selected on
single click
https://bugs.webkit.org/show_bug.cgi?id=117864

Attachment 205150: Fixed non-mac builds
https://bugs.webkit.org/attachment.cgi?id=205150&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=205150&action=review


> Source/WebCore/page/EventHandler.cpp:647
> +#if ENABLE(USERSELECT_ALL)
> +    return node->canStartSelection() ||
Position::rootUserSelectAllForNode(node);
> +#else
> +    return node->canStartSelection();
> +#endif

Slightly nicer to refactor so we don’t repeat canStartSelection twice.