[webkit-reviews] review granted: [Bug 118206] Cached pages don't update their backing scale factor when it changes : [Attachment 205750] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 28 15:55:48 PDT 2013


Tim Horton <thorton at apple.com> has granted Beth Dakin <bdakin at apple.com>'s
request for review:
Bug 118206: Cached pages don't update their backing scale factor when it
changes
https://bugs.webkit.org/show_bug.cgi?id=118206

Attachment 205750: Patch
https://bugs.webkit.org/attachment.cgi?id=205750&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=205750&action=review


> Source/WebCore/history/CachedPage.h:74
> +    bool m_needsDeviceScaleChanged;

I don't really like the "needs XYZ changed" naming (it's really 'needs to
*call* XYZChanged', or maybe needsDeviceScaleUpdate or something), but there's
already one like that here :|


More information about the webkit-reviews mailing list