[webkit-reviews] review denied: [Bug 118195] [Tools] Add support for "webKitBranchBuild" git option when calculating jhbuildPath : [Attachment 205727] Patch

[bugzilla-daemon at webkit.org]

Daniel Bates <dbates at webkit.org> has denied Nick Diego Yamane (diegoyam)
<nick.yamane at openbossa.org>'s request for review:
Bug 118195: [Tools] Add support for "webKitBranchBuild" git option when
calculating jhbuildPath
https://bugs.webkit.org/show_bug.cgi?id=118195

Attachment 205727: Patch
https://bugs.webkit.org/attachment.cgi?id=205727&action=review

------- Additional Comments from Daniel Bates <dbates at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=205727&action=review


> Tools/Scripts/webkitdirs.pm:1884
> +	   pop(@jhbuildPath);

This line is error prone as it depends on the implementation detail that
baseProductDir() always appends a "/" to the end of the base product path when
it's a Git branch build by line 239 of webkitdirs.pm (r152104),
<http://trac.webkit.org/browser/trunk/Tools/Scripts/webkitdirs.pm?rev=152104#L2
39>. This detail is likely to change as we move towards using File::Spec
operations to build a file system path instead of string concatenation to build
a path. I suggest that we pop() the last directory only if it's a Git branch
build and gitBranch() is a non-empty string.