[webkit-reviews] review requested: [Bug 115610] Add Support for mspace element : [Attachment 205723] Patch V7

[bugzilla-daemon at webkit.org]

Frédéric Wang <fred.wang at free.fr> has asked  for review:
Bug 115610: Add Support for mspace element
https://bugs.webkit.org/show_bug.cgi?id=115610

Attachment 205723: Patch V7
https://bugs.webkit.org/attachment.cgi?id=205723&action=review

------- Additional Comments from Frédéric Wang <fred.wang at free.fr>
Some remarks:

- Dynamically changes via Javascript does not seem to work. That seems to be a
general issue in WebKit MathML (e.g. with linethickness), so that should better
be fixed in a separate bug.

- The parsing of pt and pc was broken when I replaced float constants by
integers in the MathML length patch. This is fixed and tested here.

- I had hard time to edit the XCode make file by hand and finally tried a
Python script suggested by Martin. However, the changes do not seem really
consistent with the existing source code so I'd appreciate if someone with a
Mac can edit that file with XCode.