[webkit-reviews] review granted: [Bug 118160] Add IAccessibilityDelegate implementation to WinLauncher for testing purposes. : [Attachment 205652] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 28 08:46:51 PDT 2013


Brent Fulgham <bfulgham at webkit.org> has granted Roger Fong
<roger_fong at apple.com>'s request for review:
Bug 118160: Add IAccessibilityDelegate implementation to WinLauncher for
testing purposes.
https://bugs.webkit.org/show_bug.cgi?id=118160

Attachment 205652: patch
https://bugs.webkit.org/attachment.cgi?id=205652&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=205652&action=review


r=me.

>> Tools/WinLauncher/AccessibilityDelegate.cpp:26
>> +#include "stdafx.h"
> 
> Found other header before WebCore config.h. Should be: config.h, primary
header, blank line, and then alphabetically sorted.  [build/include_order] [4]

We should file a bug against style-check for StdAfx.h support.


More information about the webkit-reviews mailing list