[webkit-reviews] review granted: [Bug 118191] Get rid of IsWorkerGlobalScope and ExtendsDOMGlobalObject extended attributes : [Attachment 205713] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 28 07:37:38 PDT 2013


Kentaro Hara <haraken at chromium.org> has granted Christophe Dumez
<dchris at gmail.com>'s request for review:
Bug 118191: Get rid of IsWorkerGlobalScope and ExtendsDOMGlobalObject extended
attributes
https://bugs.webkit.org/show_bug.cgi?id=118191

Attachment 205713: Patch
https://bugs.webkit.org/attachment.cgi?id=205713&action=review

------- Additional Comments from Kentaro Hara <haraken at chromium.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=205713&action=review


Looks like good refactoring.

> Source/WebCore/workers/WorkerGlobalScope.idl:31
>      JSCustomGetOwnPropertySlotAndDescriptor,

BTW, now JSC is the only engine in WebKIt, it wouldn't make sense to prefix
JSC-specific IDL attributes with "JS".


More information about the webkit-reviews mailing list