[webkit-reviews] review denied: [Bug 117365] [CSS Regions] RenderRegions should have a RenderLayer+Backing when they contain a Composited RenderLayer : [Attachment 204545] Patch V1

[bugzilla-daemon at webkit.org]

Dave Hyatt <hyatt at apple.com> has denied Alexandru Chiculita
<achicu at adobe.com>'s request for review:
Bug 117365: [CSS Regions] RenderRegions should have a RenderLayer+Backing when
they contain a Composited RenderLayer
https://bugs.webkit.org/show_bug.cgi?id=117365

Attachment 204545: Patch V1
https://bugs.webkit.org/attachment.cgi?id=204545&action=review

------- Additional Comments from Dave Hyatt <hyatt at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=204545&action=review


r-

> Source/WebCore/rendering/RenderBox.cpp:169
> +RenderBlock* RenderBox::containingBlockForFloatingObject()

I think this needs to be renamed. containingBlock is a precise CSS term, and
that is not what you're returning here. This is the outermost block that has
the float in its floating object list. outermostBlockContainingFloatingObject
is probably ok.