[webkit-reviews] review granted: [Bug 118104] Web Inspector: AX: Add container ARIA roles (toolbar, main, labeled regions, etc.) so the layout is more discoverable to screen reader users : [Attachment 205617] patch with review feedback

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has granted James Craig
<james at cookiecrook.com>'s request for review:
Bug 118104: Web Inspector: AX: Add container ARIA roles (toolbar, main, labeled
regions, etc.) so the layout is more discoverable to screen reader users
https://bugs.webkit.org/show_bug.cgi?id=118104

Attachment 205617: patch with review feedback
https://bugs.webkit.org/attachment.cgi?id=205617&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=205617&action=review


> UserInterface/SidebarPanel.js:42
> +    if (role) 
> +	   this._element.setAttribute("role", role);
> +    else 
> +	   this._element.setAttribute("role", "group");

this._element.setAttribute("role", role || "group");

> UserInterface/ButtonNavigationItem.js:39
> +    if (role) 
> +	   this._element.setAttribute("role", role);
> +    else 
> +	   this._element.setAttribute("role", "button");

this._element.setAttribute("role", role || "button");

> UserInterface/Main.js:172
> +    this.rightSidebar = this.detailsSidebar = new
WebInspector.Sidebar(document.getElementById("details-sidebar"),
WebInspector.Sidebar.Sides.Right, "group", WebInspector.UIString("Details"));

Could pass null for the role. Why not give the navigationSidebar a label too?