[webkit-reviews] review granted: [Bug 118078] Polish context menus for media elements : [Attachment 205542] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 27 09:56:46 PDT 2013


Eric Carlson <eric.carlson at apple.com> has granted Ruth Fong
<ruthiecftg at gmail.com>'s request for review:
Bug 118078: Polish context menus for media elements
https://bugs.webkit.org/show_bug.cgi?id=118078

Attachment 205542: Patch
https://bugs.webkit.org/attachment.cgi?id=205542&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=205542&action=review


> Source/WebCore/ChangeLog:9
> +	   No new tests. media/context-menu-action.html,

Nit: I think you meant to use a comma instead of a period here.

> Source/WebKit2/ChangeLog:13
> +2013-06-26  Ruth Fong  <ruth_fong at apple.com>
> +
> +	   Polish context menus for media elements
> +	   https://bugs.webkit.org/show_bug.cgi?id=118078
> +	   <rdar://problem/14278960>
> +
> +	   Reviewed by NOBODY (OOPS!).
> +
> +	   * Shared/API/c/WKContextMenuItemTypes.h:
> +	   * Shared/API/c/WKSharedAPICast.h:
> +	   Added new type of context menu item that allows
> +	   toggling between "Show Controls" and "Hide Controls".
> +

This is not needed.


More information about the webkit-reviews mailing list