[webkit-reviews] review granted: [Bug 118123] Porting spellcheck tests from layout tests to unit tests. : [Attachment 205594] Proposed patch version 3

[bugzilla-daemon at webkit.org]

Christophe Dumez <dchris at gmail.com> has granted Dariusz Frankiewicz
<d.frankiewic at samsung.com>'s request for review:
Bug 118123: Porting spellcheck tests from layout tests to unit tests.
https://bugs.webkit.org/show_bug.cgi?id=118123

Attachment 205594: Proposed patch version 3
https://bugs.webkit.org/attachment.cgi?id=205594&action=review

------- Additional Comments from Christophe Dumez <dchris at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=205594&action=review


Looks fine. r=me with nits. Please fix the nits and let Grzegorz take a look
before landing.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:340
> +    unsigned numberItemsWithSpellCheck = contextMenuItemsNumber;

nit: Local variable not needed.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:369
> +    unsigned numberItemsWithSpellCheck = contextMenuItemsNumber;

nit: Local variable not needed.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:398
> +    unsigned numberItemsWithSpellCheck = contextMenuItemsNumber;

nit: Local variable not needed.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:428
> +    unsigned numberItemsWithSpellCheck = contextMenuItemsNumber;

nit: Local variable not needed.