[webkit-reviews] review denied: [Bug 118123] Porting spellcheck tests from layout tests to unit tests. : [Attachment 205583] Proposed patch

[bugzilla-daemon at webkit.org]

Christophe Dumez <dchris at gmail.com> has denied Dariusz Frankiewicz
<d.frankiewic at samsung.com>'s request for review:
Bug 118123: Porting spellcheck tests from layout tests to unit tests.
https://bugs.webkit.org/show_bug.cgi?id=118123

Attachment 205583: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=205583&action=review

------- Additional Comments from Christophe Dumez <dchris at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=205583&action=review


> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:328
> +    waitUntilTrue(wasContextMenuShown);

You need to ASSERT_TRUE iirc.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:337
> +    waitUntilTrue(wasContextMenuShown);

You need to ASSERT_TRUE iirc.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:356
> +    waitUntilTrue(wasContextMenuShown);

You need to ASSERT_TRUE iirc.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:357
> +    size_t numberItemsWithoutSpellCheck = contextMenuItemsNumber;

unsigned.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:361
> +    // Testing how many items are in context menu when multiword are
selected.

"multiple words"

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:366
> +    waitUntilTrue(wasContextMenuShown);

You need to ASSERT_TRUE iirc.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:367
> +    size_t numberItemsWithSpellCheck = contextMenuItemsNumber;

unsigned

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:385
> +    waitUntilTrue(wasContextMenuShown);

You need to ASSERT_TRUE iirc.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:386
> +    size_t numberItemsWithoutSpellCheck = contextMenuItemsNumber;

unsigned

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:395
> +    waitUntilTrue(wasContextMenuShown);

You need to ASSERT_TRUE iirc.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:396
> +    size_t numberItemsWithSpellCheck = contextMenuItemsNumber;

unsigned

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:400
> +    wasContextMenuShown = false;

boolean reset

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:414
> +    waitUntilTrue(wasContextMenuShown);

You need to ASSERT_TRUE iirc.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:415
> +    size_t numberItemsWithoutSpellCheck = contextMenuItemsNumber;

unsigned