[webkit-reviews] review granted: [Bug 115976] Web Inspector: AX: Console log of the Inspector does not announce output for screen readers : [Attachment 205535] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 26 17:09:03 PDT 2013


Timothy Hatcher <timothy at apple.com> has granted James Craig
<james at cookiecrook.com>'s request for review:
Bug 115976: Web Inspector: AX: Console log of the Inspector does not announce
output for screen readers
https://bugs.webkit.org/show_bug.cgi?id=115976

Attachment 205535: patch
https://bugs.webkit.org/attachment.cgi?id=205535&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=205535&action=review


> Source/WebInspectorUI/UserInterface/LogContentView.js:38
> +    this.messagesElement.setAttribute('role', 'log');

Should always use double quotes.

> Source/WebInspectorUI/UserInterface/ConsoleCommandResult.js:49
> +	   element.setAttribute('data-labelprefix',
WebInspector.UIString("Output: "));

Should always use double quotes.


More information about the webkit-reviews mailing list