[webkit-reviews] review denied: [Bug 118094] Add an accessibility delegate interface to Windows solution : [Attachment 205537] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 26 16:23:20 PDT 2013


Brent Fulgham <bfulgham at webkit.org> has denied Roger Fong
<roger_fong at apple.com>'s request for review:
Bug 118094: Add an accessibility delegate interface to Windows solution
https://bugs.webkit.org/show_bug.cgi?id=118094

Attachment 205537: patch
https://bugs.webkit.org/attachment.cgi?id=205537&action=review

------- Additional Comments from Brent Fulgham <bfulgham at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=205537&action=review


Looks good -- but we're missing the AccessibilityDelegate.idl file!

> Source/WebKit/win/WebView.cpp:2885
> +	   return E_FAIL;

I usually return E_POINTER


More information about the webkit-reviews mailing list