[webkit-reviews] review granted: [Bug 118074] Add JSStringCreateWithCharactersNoCopy SPI : [Attachment 205520] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Anders Carlsson
<andersca at apple.com>'s request for review:
Bug 118074: Add JSStringCreateWithCharactersNoCopy SPI
https://bugs.webkit.org/show_bug.cgi?id=118074

Attachment 205520: Patch
https://bugs.webkit.org/attachment.cgi?id=205520&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=205520&action=review


r=me

> Source/WTF/wtf/text/StringImpl.h:774
> +	   else

No else, please.

> Source/WTF/wtf/text/StringImpl.h:1367
> +	   else

Ditto.

> Source/WTF/wtf/text/StringImpl.h:1373
> -    return create(m_data16, m_length);
> +    else

Boo.