[webkit-reviews] review requested: [Bug 117497] Improve algorithm of removing user and pass, by seperating new function : [Attachment 205476] code refactoring as mentioned of reviewer

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 26 05:17:42 PDT 2013


Meeyoung Kim <meeyoung.kim at lge.com> has asked  for review:
Bug 117497: Improve algorithm of removing user and pass, by seperating new
function
https://bugs.webkit.org/show_bug.cgi?id=117497

Attachment 205476: code refactoring as	mentioned of reviewer
https://bugs.webkit.org/attachment.cgi?id=205476&action=review

------- Additional Comments from Meeyoung Kim <meeyoung.kim at lge.com>

I tried to find a way to measure the performance though, it was required to
make URL requests in the testcase to see the difference and the result are very
affected by many external variables such as network, resource loading etc. 

As you mentioned before, it is small performance optimization amd fixes are so
trivial that I think it's not a problem appying path without measurment.


More information about the webkit-reviews mailing list