[webkit-reviews] review granted: [Bug 116897] [Qt] Build overrides -j when given --makeargs="-sj40" : [Attachment 203103] Patch

[bugzilla-daemon at webkit.org]

Csaba Osztrogonac <ossy at webkit.org> has granted Brendan Long
<b.long at cablelabs.com>'s request for review:
Bug 116897: [Qt] Build overrides -j when given --makeargs="-sj40"
https://bugs.webkit.org/show_bug.cgi?id=116897

Attachment 203103: Patch
https://bugs.webkit.org/attachment.cgi?id=203103&action=review

------- Additional Comments from Csaba Osztrogonac <ossy at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=203103&action=review


> Tools/Scripts/webkitdirs.pm:2227
> -    if ($make eq "make" && $makeargs !~ /-j\s*\d+/i && (!defined
$ENV{"MAKEFLAGS"} || ($ENV{"MAKEFLAGS"} !~ /-j\s*\d+/i ))) {
> +    if ($make eq "make" && $makeargs !~ /-[^\s]*?j\s*\d+/i && (!defined
$ENV{"MAKEFLAGS"} || ($ENV{"MAKEFLAGS"} !~ /-j\s*\d+/i ))) {

LGTM, but please fix the regexp of MAKEFLAGS too.