[webkit-reviews] review granted: [Bug 117967] fourthTier: DFG should support switch_string : [Attachment 205421] the patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 117967: fourthTier: DFG should support switch_string
https://bugs.webkit.org/show_bug.cgi?id=117967

Attachment 205421: the patch
https://bugs.webkit.org/attachment.cgi?id=205421&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=205421&action=review


> Source/JavaScriptCore/dfg/DFGBinarySwitch.h:46
> +// Use this like so:
> +//
> +// BinarySwitch switch(valueReg, casesVector, BinarySwitch::Int32);
> +// while (switch.advance(jit)) {
> +//	  int value = switch.caseValue();
> +//	  unsigned index = switch.caseIndex(); // index into casesVector, above

> +//	  ... // generate code for this case
> +// }
> +// switch.fallThrough().link(&jit);

I think this could use a description of what a BinarySwitch is going to be used
for.