[webkit-reviews] review denied: [Bug 117922] [Qt][WK2] need API for clearMemoryCaches like WK1 : [Attachment 205351] patch

[bugzilla-daemon at webkit.org]

Sam Weinig <sam at webkit.org> has denied Sangho Kim <thomas.kim at lge.com>'s
request for review:
Bug 117922: [Qt][WK2] need API for clearMemoryCaches like WK1
https://bugs.webkit.org/show_bug.cgi?id=117922

Attachment 205351: patch
https://bugs.webkit.org/attachment.cgi?id=205351&action=review

------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=205351&action=review


> Source/WebKit2/WebProcess/WebProcess.cpp:756
> +#if !PLATFORM(MAC)
> +    // Drop JIT compiled code from ExecutableAllocator.
> +    WebCore::gcController().discardAllCompiledCode();
> +    // Garbage Collect to release the references of CachedResource from dead
objects.
> +    WebCore::gcController().garbageCollectNow();
> +
> +    WTF::releaseFastMallocFreeMemory();
> +#endif

These are not caches and thus should not be here.  It is also generally a bad
idea to force a GC like this.