[webkit-reviews] review granted: [Bug 117937] Adopt is/toHTMLFormElement for code cleanup : [Attachment 205299] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Mon Jun 24 12:38:42 PDT 2013


Andreas Kling <akling at apple.com> has granted Kangil Han
<kangil.han at samsung.com>'s request for review:
Bug 117937: Adopt is/toHTMLFormElement for code cleanup
https://bugs.webkit.org/show_bug.cgi?id=117937

Attachment 205299: Patch
https://bugs.webkit.org/attachment.cgi?id=205299&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=205299&action=review


r=me

> Source/WebKit2/WebProcess/WebPage/WebFrame.cpp:601
> -	   if (toElement(node)->hasTagName(HTMLNames::formTag))
> +	   if (isHTMLFormElement(toElement(node)))

We don't need the toElement() here; isHTMLFormElement() takes a Node*.


More information about the webkit-reviews mailing list