[webkit-reviews] review granted: [Bug 117907] "Refactor adding a line break" : [Attachment 205243] Patch

[bugzilla-daemon at webkit.org]

Ryosuke Niwa <rniwa at webkit.org> has granted Robert Hogan <robert at webkit.org>'s
request for review:
Bug 117907: "Refactor adding a line break"
https://bugs.webkit.org/show_bug.cgi?id=117907

Attachment 205243: Patch
https://bugs.webkit.org/attachment.cgi?id=205243&action=review

------- Additional Comments from Ryosuke Niwa <rniwa at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=205243&action=review


> Source/WebCore/rendering/RenderBlockLineLayout.cpp:2866
> +static inline void addLineBreak(LineWidth& width, InlineIterator& lBreak,
RenderObject* object, unsigned offset = 0, int nextBreak = -1)

I feel like this function name is too generic.
commitLineBreakAtCurrentWidth? breakLineAtCurrentWidth or
commitCurrentWidthAsLineBreak?