[webkit-reviews] review denied: [Bug 110236] [CMake] Undefined references should be detected at build time : [Attachment 190258] Patch

[bugzilla-daemon at webkit.org]

Laszlo Gombos <laszlo.gombos at webkit.org> has denied Balazs Kelemen
<kbalazs at webkit.org>'s request for review:
Bug 110236: [CMake] Undefined references should be detected at build time
https://bugs.webkit.org/show_bug.cgi?id=110236

Attachment 190258: Patch
https://bugs.webkit.org/attachment.cgi?id=190258&action=review

------- Additional Comments from Laszlo Gombos <laszlo.gombos at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=190258&action=review


Overall this patch needs another iteration to address Raphael's and my
comments.

> Source/WebCore/ChangeLog:8
> +	   Push --no-undefined to the linker if building on Linux.

Pass the --no-undefined argument to the linker when building on Linux.

> Source/WebKit2/ChangeLog:8
> +	   Push --no-undefined to the linker if building on Linux.

Ditto.