[webkit-reviews] review granted: [Bug 117927] Web Inspector: WebInspector.displayNameForURL() failure prevents DOM inspection : [Attachment 205288] Patch

[bugzilla-daemon at webkit.org]

Timothy Hatcher <timothy at apple.com> has granted Antoine Quint
<graouts at apple.com>'s request for review:
Bug 117927: Web Inspector: WebInspector.displayNameForURL() failure prevents
DOM inspection
https://bugs.webkit.org/show_bug.cgi?id=117927

Attachment 205288: Patch
https://bugs.webkit.org/attachment.cgi?id=205288&action=review

------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=205288&action=review


We should probably guard WebInspector.updateWindowTitle and parseQueryString
too.

> Source/WebInspectorUI/UserInterface/Main.js:360
> +	   displayName = decodeURIComponent(urlComponents.lastPathComponent ||
"");
> +    } catch (e) {
> +	   // Ignore possible URIError.

We should fallback to urlComponents.lastPathComponent (not decoded) for
displayName in the catch.