[webkit-reviews] review granted: [Bug 117610] [CSS Shapes] limit shape image values to same origin : [Attachment 205227] Patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has granted Hans Muller
<giles_joplin at yahoo.com>'s request for review:
Bug 117610: [CSS Shapes] limit shape image values to same origin
https://bugs.webkit.org/show_bug.cgi?id=117610

Attachment 205227: Patch
https://bugs.webkit.org/attachment.cgi?id=205227&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=205227&action=review


r=me

> Source/WebCore/css/CSSImageValue.h:25
> +#include "CachedResourceLoader.h"

It is very undesirable to add loader related includes to CSS and rendering
headers that had none. CachedResourceLoader.h will bring in a huge amount of
headers into each file that includes CSSImageValue.h, and this kind of stuff
has dramatic effects on compilation time.

Please don't add this include.

Very sorry for not catching this earlier.

> Source/WebCore/loader/cache/CachedResourceLoader.cpp:338
>	   // FIXME: Are we sure about CachedResource::FontResource?

Even this is still misplaced. The right place for this FIXME is now where font
resources get their options.

If you can't find a good place for it, I suggest just removing it. Our
cross-origin rules for fonts are a well known choice, and there are (were?)
bugs in bugzilla.