[webkit-reviews] review granted: [Bug 117884] Update platform text track menu : [Attachment 205203] Proposed patch

[bugzilla-daemon at webkit.org]

Jer Noble <jer.noble at apple.com> has granted Eric Carlson
<eric.carlson at apple.com>'s request for review:
Bug 117884: Update platform text track menu
https://bugs.webkit.org/show_bug.cgi?id=117884

Attachment 205203: Proposed patch
https://bugs.webkit.org/attachment.cgi?id=205203&action=review

------- Additional Comments from Jer Noble <jer.noble at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=205203&action=review


> Source/WebCore/platform/graphics/PlatformTextTrack.h:66
> -    static PassRefPtr<PlatformTextTrack> create(PlatformTextTrackClient*
client, const String& label, const String& language, TrackKind kind, TrackType
type)
> +    static PassRefPtr<PlatformTextTrack> create(PlatformTextTrackClient*
client, const String& label, const String& language, TrackKind kind, TrackType
type, int uniqueId)
>      {
> -	   return adoptRef(new PlatformTextTrack(client, label, language, kind,
type));
> +	   return adoptRef(new PlatformTextTrack(client, label, language, kind,
type, uniqueId));
>      }

This will break the call point in TextTrack.cpp -
TextTrack::platformTextTrack(), which does not pass in a uniqueId.  Please
update that call before you land.