[webkit-reviews] review granted: [Bug 117835] [CSS Regions] Move overset compute code from flow thread to named flow thread : [Attachment 205187] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jun 21 08:53:33 PDT 2013


Andreas Kling <akling at apple.com> has granted Radu Stavila <stavila at adobe.com>'s
request for review:
Bug 117835: [CSS Regions] Move overset compute code from flow thread to named
flow thread
https://bugs.webkit.org/show_bug.cgi?id=117835

Attachment 205187: Patch
https://bugs.webkit.org/attachment.cgi?id=205187&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=205187&action=review


r=me with a suggestion:

> Source/WebCore/rendering/RenderRegion.cpp:136
> +    ASSERT(node() && node()->isElementNode());

Maybe we could add an element() helper, to avoid having to check/cast all the
time.

> Source/WebCore/rendering/RenderRegion.cpp:146
> +    ASSERT(node() && node()->isElementNode());

etc.


More information about the webkit-reviews mailing list