[webkit-reviews] review granted: [Bug 117508] [CSS Regions] Add new regionOversetChange event : [Attachment 205083] Patch without inspector changes

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Radu Stavila <stavila at adobe.com>'s
request for review:
Bug 117508: [CSS Regions] Add new regionOversetChange event
https://bugs.webkit.org/show_bug.cgi?id=117508

Attachment 205083: Patch without inspector changes
https://bugs.webkit.org/attachment.cgi?id=205083&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=205083&action=review


> Source/WebCore/rendering/RenderRegion.cpp:136
> +    if (isValid() && node() && node()->isElementNode())

Can node ever actually be anything else than Element? If not then the element
test should be removed (toElement() asserts).

It would be nicer to reverse the conditions and bail out fast on error case.

> Source/WebCore/rendering/RenderRegion.cpp:145
> +    if (node() && node()->isElementNode())
> +	   toElement(node())->setRegionOversetState(state);

Here too.