[webkit-reviews] review denied: [Bug 117828] [EFL][WK2] TextCheckerClientEfl doesn't free Eina_List that store client spelling suggestion : [Attachment 205079] proposed patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jun 20 06:28:48 PDT 2013


Christophe Dumez <dchris at gmail.com> has denied Grzegorz Czajkowski
<g.czajkowski at samsung.com>'s request for review:
Bug 117828: [EFL][WK2] TextCheckerClientEfl doesn't free Eina_List that store
client spelling suggestion
https://bugs.webkit.org/show_bug.cgi?id=117828

Attachment 205079: proposed patch
https://bugs.webkit.org/attachment.cgi?id=205079&action=review

------- Additional Comments from Christophe Dumez <dchris at gmail.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=205079&action=review


> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_text_checker.cpp:304
> +    eina_list_free(loadedLanguages);

I don't believe this is needed after EINA_LIST_FREE()... We probably just need
to update the doc?


More information about the webkit-reviews mailing list