[webkit-reviews] review granted: [Bug 117481] Make sure to use CSSValueID and CSSPropertyID rather than integers : [Attachment 205030] with benjamin's comments

[bugzilla-daemon at webkit.org]

Benjamin Poulain <benjamin at webkit.org> has granted Alexis Menard (darktears)
<alexis at webkit.org>'s request for review:
Bug 117481: Make sure to use CSSValueID and CSSPropertyID rather than integers
https://bugs.webkit.org/show_bug.cgi?id=117481

Attachment 205030: with benjamin's comments
https://bugs.webkit.org/attachment.cgi?id=205030&action=review

------- Additional Comments from Benjamin Poulain <benjamin at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=205030&action=review


LGTM

> Source/WebCore/css/CSSValuePool.cpp:58
> +    ASSERT(ident < numCSSValueKeywords);
>      if (!m_identifierValueCache[ident])

You should have a full bound checking release assert here.