[webkit-reviews] review denied: [Bug 115123] AX: aria-required is not exposed on all expected roles : [Attachment 204981] patch

[bugzilla-daemon at webkit.org]

chris fleizach <cfleizach at apple.com> has denied  review:
Bug 115123: AX: aria-required is not exposed on all expected roles
https://bugs.webkit.org/show_bug.cgi?id=115123

Attachment 204981: patch
https://bugs.webkit.org/attachment.cgi?id=204981&action=review

------- Additional Comments from chris fleizach <cfleizach at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=204981&action=review


> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:1023
> +    // required attr exposed on various HTML elements...

These lines should be in the form of sentences.

> Source/WebCore/accessibility/mac/WebAccessibilityObjectWrapperMac.mm:1033
> +	   || m_object->isTree()

We should move this logic into a method like, supportsRequiredAttribute()
We should also switch to using a switch statement on the role which will be
baster

switch (roleValue()) {
  case ComboBox:
  case Tree:
     ….
}