[webkit-reviews] review denied: [Bug 117538] [GTK] MiniBrowser doesn't solve the saving location when there are no XDG settings : [Attachment 204427] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Wed Jun 19 10:07:49 PDT 2013


Carlos Garcia Campos <cgarcia at igalia.com> has denied Andres Gomez Garcia
<agomez at igalia.com>'s request for review:
Bug 117538: [GTK] MiniBrowser doesn't solve the saving location when there are
no XDG settings
https://bugs.webkit.org/show_bug.cgi?id=117538

Attachment 204427: Patch
https://bugs.webkit.org/attachment.cgi?id=204427&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
This looks good to me, but I think this is actually a bug in the default
implementation of decide-destination. Let's fix it in WebKitDownload and all
other apps using the API will benefit from it. Note that in this case we would
be updating the internal destination to NULL and emitting the notify signal.


More information about the webkit-reviews mailing list