[webkit-reviews] review denied: [Bug 117266] [WK2] Looping for EINTR on close() is incorrect for Linux, at least : [Attachment 204849] Patch

[bugzilla-daemon at webkit.org]

Darin Adler <darin at apple.com> has denied Sergio Correia
<sergio.correia at openbossa.org>'s request for review:
Bug 117266: [WK2] Looping for EINTR on close() is incorrect for Linux, at least
https://bugs.webkit.org/show_bug.cgi?id=117266

Attachment 204849: Patch
https://bugs.webkit.org/attachment.cgi?id=204849&action=review

------- Additional Comments from Darin Adler <darin at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=204849&action=review


Looks OK, needs to not be a class, though.

> Source/WTF/wtf/UniStdExtras.h:34
> +class UniStdExtras {

This should not be a class.

> Source/WTF/wtf/UniStdExtras.h:36
> +    static int close(int fileDescriptor)

Should just have a global function with a descriptive name. Something like
closeWithRetry maybe.

> Source/WTF/wtf/UniStdExtras.h:53
> +} // namespace WTF

Need the using that we do in WTF. Like this:

    using WTF::closeWithRetry;